As more young people identify as transgender, a fight has re-emerged over therapy that questions their gender identities.